Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tests for CONFIG argument #230

Merged
merged 5 commits into from
Apr 12, 2022
Merged

Adding tests for CONFIG argument #230

merged 5 commits into from
Apr 12, 2022

Conversation

harshmahesheka
Copy link
Contributor

@harshmahesheka harshmahesheka commented Apr 9, 2022 •
edited
Loading

🎉 New feature

Requires #211

Summary

Adds tests for CONFIG argument in ign_find_packages().The idea being ign_find_package(ignition-find_config) will search for Findignition-find_config.cmake before ignition-find_configConfig.cmake in MODULE mode whereas when we pass CONFIG option it will skip to CONFIG mode and directly search for ignition-find_configConfig.cmake.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@harshmahesheka
Adding tests for CONFIG
b5536ca 
Signed-off-by: Harsh Mahesheka <[email protected]>
@harshmahesheka
Adding tests for CONFIG 2
881145e 
Signed-off-by: Harsh Mahesheka <[email protected]>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Apr 9, 2022
@harshmahesheka harshmahesheka changed the title Test config Adding tests for CONFIG argument Apr 9, 2022
adlarkin
adlarkin reviewed Apr 11, 2022
View reviewed changes
examples/use_config_ifp/CMakeLists.txt Outdated Show resolved Hide resolved
examples/use_config_ifp/CMakeLists.txt Outdated Show resolved Hide resolved
@harshmahesheka
Adding src and readme
3cd23be 
Signed-off-by: Harsh Mahesheka <[email protected]>
@adlarkin adlarkin merged commit c66786d into gazebosim:ign-cmake2 Apr 12, 2022
@harshmahesheka harshmahesheka deleted the test_config branch April 12, 2022 17:51
scpeters
scpeters reviewed Apr 12, 2022
View reviewed changes
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the new tests print console messages so you can see interactively if it is working, but not otherwise. It would be nice if the test would fail if the wrong cmake file was found, perhaps by setting variables and then expecting them to have a certain value and reporting a cmake error if the expected value was not found, but that can be future work.

Thanks for your contribution!

@harshmahesheka
Copy link
Contributor Author

expecting them to have a certain value and reporting a cmake error if the expected value was not found, but that can be future work.

Yeah, we can do it this way also. Should I make the changes and open a pr?

@adlarkin
Copy link
Contributor

expecting them to have a certain value and reporting a cmake error if the expected value was not found, but that can be future work.

Yeah, we can do it this way also. Should I make the changes and open a pr?

A new PR would be great. I can review it once you have a PR opened. Thanks for iterating!

@harshmahesheka harshmahesheka mentioned this pull request Apr 14, 2022
Merged
8 tasks
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-releases-2022-04-27-fortress-citadel/1389/1

harshmahesheka added a commit to harshmahesheka/ign-cmake that referenced this pull request May 24, 2022
@harshmahesheka @adlarkin
Adding tests for CONFIG argument (gazebosim#230)
047cb58 
Signed-off-by: Harsh Mahesheka <[email protected]>

Co-authored-by: Ashton Larkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters left review comments

@adlarkin adlarkin adlarkin approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshmahesheka @adlarkin @osrf-triage @scpeters